refactor: drop using internal modules #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoln
requested review from
partiallyordered,
sridharvoruganti,
kleyow,
bushjames and
lewisdaly
56 tasks
|
please don't merge! @kleyow is fixing merge issues |
…fix/2060_local_package_install
eoln
dismissed stale reviews from bushjames and sridharvoruganti
via
16441e7
kleyow
approved these changes
Feb 24, 2021
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
file:when specifying the dependencies unable to use sdk-scheme-adapter as npm module -> thenpm installfails with ENOLOCAL.According to npm documentation
file:feature shouldn't be used when we want to make module public in npm repository:https://docs.npmjs.com/cli/v7/configuring-npm/package-json
This feature is helpful for local offline development and creating tests that require npm installing where you don't want to hit an external server, but should not be used when publishing packages to the public registry.